v0.13.0 tools/tcptracer ipv6 support is broken

[Safari77]

v0.13.0 shows ports as 0 and addresses are also wrong.
In the output source IP 2003:df:5f14:d9aa:1:2:3:4 is shown as [::2003:df:5f14:d9aa], and destination IP 2a03:b0c0:3:d0:5:6:7:8 is shown as [1:2:3:4:2a03:b0c0:3:d0].

Running Fedora 30 x86_64 on Linux 4.19.106.

[yonghong-song]

Does this fixed the issue?

diff --git a/tools/tcptracer.py b/tools/tcptracer.py
index 8e6e1ec2..63a4e626 100755
--- a/tools/tcptracer.py
+++ b/tools/tcptracer.py
@@ -70,12 +70,12 @@ struct tcp_ipv6_event_t {
     u32 type;
     u32 pid;
     char comm[TASK_COMM_LEN];
-    u8 ip;
     unsigned __int128 saddr;
     unsigned __int128 daddr;
     u16 sport;
     u16 dport;
     u32 netns;
+    u8 ip;
 };
 BPF_PERF_OUTPUT(tcp_ipv6_event);

Probably some recent change to convert C structures to python structures which does not support __int128 type had some regressions.

[jeromemarchand]

Does this fixed the issue?

I've seen the same problem on v0.15.0 and this fixed it.

diff --git a/tools/tcptracer.py b/tools/tcptracer.py
index 8e6e1ec2..63a4e626 100755
--- a/tools/tcptracer.py
+++ b/tools/tcptracer.py
@@ -70,12 +70,12 @@ struct tcp_ipv6_event_t {
     u32 type;
     u32 pid;
     char comm[TASK_COMM_LEN];
-    u8 ip;
     unsigned __int128 saddr;
     unsigned __int128 daddr;
     u16 sport;
     u16 dport;
     u32 netns;
+    u8 ip;
 };
 BPF_PERF_OUTPUT(tcp_ipv6_event);

Probably some recent change to convert C structures to python structures which does not support __int128 type had some regressions.

Yes it must be some alignment wrt __int128 type. There is no problem with the ipv4 structure which also have the u8 field in the same place, but no __int128 ones.