Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename deadlock_detector to deadlock #2152

Closed
brendangregg opened this issue Jan 18, 2019 · 2 comments
Closed

rename deadlock_detector to deadlock #2152

brendangregg opened this issue Jan 18, 2019 · 2 comments

Comments

@brendangregg
Copy link
Member

The name is too long (doesn't fit well on diagrams) and doesn't follow the style of the other tools. Can this please be renamed to "deadlock"?

@kennyyu
@kennyyu
Copy link
Contributor

kennyyu commented Jan 18, 2019

@brendangregg Yep! I'll send a PR after the upcoming long weekend to rename this.

kennyyu added a commit to kennyyu/bcc that referenced this issue Jan 24, 2019
@kennyyu
tools: rename "deadlock_detector" to "deadlock" (iovisor#2152)
3814897 
This renames the `deadlock_detector.py` tool to `deadlock.py` to make
the name more diagram-friendly and to be consistent with the naming of the
other tools.
yonghong-song pushed a commit that referenced this issue Jan 24, 2019
@kennyyu @yonghong-song
tools: rename "deadlock_detector" to "deadlock" (#2152) (#2160)
9e0817a 
This renames the `deadlock_detector.py` tool to `deadlock.py` to make
the name more diagram-friendly and to be consistent with the naming of the
other tools.
navytux added a commit to navytux/bcc that referenced this issue Feb 7, 2019
@navytux
Merge branch 'master' into x/pinglat
a763587 
* master: (609 commits)
  docs: references_guide.md: add/fix search examples/tools links (iovisor#2186)
  Fix misc file permissions (iovisor#2185)
  sync with latest bpf (iovisor#2184)
  sync with latest libbpf repo (iovisor#2183)
  docs: fix broken link of bpf_log2l(iovisor#2176)
  examples/tracing: some minor fixes
  Fix tools/syscount -l (iovisor#2180)
  examples/tracing/bitehist.py: add example of linear histogram (iovisor#2177)
  cachestat: bring back HITRATIO column
  Fix debuginfo search on Ubuntu
  Add installation instructions for Amazon Linux 1 AMI Sign-Off-By Travis Davies <[email protected]>
  [iovisor/bcc] trace: Incorrect symbol offsets when using build_id (iovisor#2161) (iovisor#2162)
  profile: exclude CPU idle stacks by default (iovisor#2166)
  fix cpuunclaimed.py with cfs_rq structure change (iovisor#2164)
  tools: rename "deadlock_detector" to "deadlock" (iovisor#2152) (iovisor#2160)
  use libbpf api in bpf_attach_xdp (iovisor#2158)
  support symbol resolution of short-lived process.  (iovisor#2144)
  profile.py: return kernel annotations for folded stacks
  use libbpf APIs from libbpf.c (iovisor#2156)
  ddos_detector.py to monitor DDOS attacks (iovisor#2140)
  ...
@Trundle
Copy link
Contributor

Trundle commented Feb 17, 2019

I think this issue can be closed, given that #2160 is merged.

palexster pushed a commit to palexster/bcc that referenced this issue Jul 7, 2019
@kennyyu
tools: rename "deadlock_detector" to "deadlock" (iovisor#2152) (iovis…
391e9a9 
…or#2160)

This renames the `deadlock_detector.py` tool to `deadlock.py` to make
the name more diagram-friendly and to be consistent with the naming of the
other tools.
CrackerCat pushed a commit to CrackerCat/bcc that referenced this issue Jul 31, 2024
@kennyyu
tools: rename "deadlock_detector" to "deadlock" (iovisor#2152) (iovis…
493e660 
…or#2160)

This renames the `deadlock_detector.py` tool to `deadlock.py` to make
the name more diagram-friendly and to be consistent with the naming of the
other tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Trundle @kennyyu @palmtenor @brendangregg