Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-power-of-2 value size not handling correctly #13

Closed
yonghong-song opened this issue May 11, 2015 · 1 comment
Closed

non-power-of-2 value size not handling correctly #13

yonghong-song opened this issue May 11, 2015 · 1 comment

Comments

@yonghong-song
Copy link
Collaborator

We should review how to handle non-power-of-2 key/value size.

At this point, I found that compiler did not generate correct code to retrieve arp packet values:

I add arp support in the proto.b:

state ethernet {
switch $ethernet.type {
case 0x0800 {
next proto::ip;
};
case 0x0806 {
next proto::arp;
};
case 0x8100 {
next proto::dot1q;
};
case * {
goto EOP;
};
}
}

struct arp {
u8 htype:16;
u8 ptype:16;
u32 hlen:8;
u32 plen:8;
u32 oper:16;
u64 sha:48;
u32 spa:32;
u64 tha:48;
u32 tpa:32;
};

state arp {
goto EOP;
}

For arp packet, in bpfdev1.b file, I have the following code to process arp packet:

state proto::arp {
if (skb.pkt_type) {
if $arp.oper == 1 {
struct MacaddrKey mac_key = {.ip = $arp.spa};
struct MacaddrLeaf mac_leaf = {.mac = $arp.sha};
log("sha\n", $arp.spa);
log("sha\n", $arp.sha);
log("sha\n", $arp.tpa);
log("sha\n", $arp.tha);
u64 sha:64 = $arp.sha;
log("sha\n", sha);
macaddr_map.update(mac_key, mac_leaf);
}
goto EOP;
}
}

For a particular arp packet, it prints out the following values:
[ 1523.499639] 0 1 8 0 6 4 0 1
[ 1523.499641] f2 8d dd 96 0 8f 14 1
[ 1523.499643] 1 3 0 0 0 0 0 0
[ 1523.499645] 14 0 0 4
[ 1523.499649] bpfdev_printk: 14010103
[ 1523.499651] bpfdev_printk: 61dddf280f00
[ 1523.499652] bpfdev_printk: 14000004
[ 1523.499654] bpfdev_printk: 1400000000
[ 1523.499656] bpfdev_printk: 61dddf280f00

ip addresses are correct, but mac addresses are not correct.

Hacked log support in the linux kernel as below.

diff --git a/net/core/filter.c b/net/core/filter.c
index ee6fe82..4a2218a 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -1201,6 +1201,14 @@ static u64 bpf_skb_store_bytes(u64 r1, u64 r2, u64 r3, u64 r4, u64 flags)
char buf[16];
void *ptr;

+{

  •   unsigned char *data = (unsigned char *)from;
    
  •   printk("%s: %s: %d, offset = %d, len = %u\n", **FILE**, **FUNCTION**, **LINE**, offset, len);
    
  •   if (len == 4) printk("%x %x %x %x\n", data[0], data[1], data[2], data[3]);
    
  •   if (len == 6) printk("%x %x %x %x %x %x\n", data[0], data[1], data[2], data[3], data[4], data[5]);
    
  •   if (len == 8) printk("%x %x %x %x %x %x %x %x\n", data[0], data[1], data[2], data[3], data[4], data[5], data[6], data[7]
    
    +}
    +
    /* bpf verifier guarantees that:
    * 'from' pointer points to bpf program stack
    * 'len' bytes of it were initialized
    @@ -1333,6 +1341,12 @@ static u64 bpf_l4_csum_replace(u64 r1, u64 r2, u64 from, u64 to, u64 flags)
    return 0;
    }

+static u64 bpfdev_printk(u64 r1, u64 fmt_size, u64 r3, u64 r4, u64 r5)
+{

  •   printk("%s: %llx\n", **FUNCTION**, r3);
    
  •   return 0;
    
    +}
    +
    const struct bpf_func_proto bpf_l4_csum_replace_proto = {
    .func = bpf_l4_csum_replace,
    .gpl_only = false,
    @@ -1344,6 +1358,14 @@ const struct bpf_func_proto bpf_l4_csum_replace_proto = {
    .arg5_type = ARG_ANYTHING,
    };

+const struct bpf_func_proto bpf_trace_printk_proto = {

  •   .func           = bpfdev_printk,
    
  •   .gpl_only       = false,
    
  •   .ret_type       = RET_INTEGER,
    
  •   .arg1_type      = ARG_PTR_TO_STACK,
    
  •   .arg2_type      = ARG_CONST_STACK_SIZE,
    
    +};
    +
    static const struct bpf_func_proto *
    sk_filter_func_proto(enum bpf_func_id func_id)
    {
    @@ -1388,6 +1410,8 @@ bpfdev_func_proto(enum bpf_func_id func_id)
    return &bpf_l3_csum_replace_proto;
    case BPF_FUNC_l4_csum_replace:
    return &bpf_l4_csum_replace_proto;
  •   case BPF_FUNC_trace_printk:
    
  •           return &bpf_trace_printk_proto;
    default:
            return sk_filter_func_proto(func_id);
    }
    
    plumgrid@yhs-plumgrid:~/misc/net-next$
@yonghong-song yonghong-song changed the title non-power-of-2 not handling correctly non-power-of-2 value size not handling correctly May 11, 2015
@drzaeus77
Copy link
Collaborator

Works now after merging #43

sebymiano pushed a commit to sebymiano/bcc that referenced this issue Dec 10, 2020
ekyooo added a commit to ekyooo/bcc that referenced this issue Feb 20, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#2  0xffffffc010084a08 el0_svc+0x8
      iovisor#3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#2  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#3  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#4  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#5  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#6  0xffffffc0100843b0 el0_da+0x1c
      iovisor#7  0xffffffc01027daa4 generic_copy_file_checks+0x334
      --
  failed to get syms
      iovisor#8  0x0000007f8dc12648
      iovisor#9  0x0000007f8dc0aef8
      iovisor#10 0x0000007f8dc1c990
      iovisor#11 0x0000007f8dc08b0c
      iovisor#12 0x0000007f8dc08e48
      iovisor#13 0x0000007f8dc081c8
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Feb 20, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#2  0xffffffc010084a08 el0_svc+0x8
      iovisor#3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#2  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#3  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#4  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#5  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#6  0xffffffc0100843b0 el0_da+0x1c
      iovisor#7  0xffffffc01027daa4 generic_copy_file_checks+0x334
      --
  failed to get syms
      iovisor#8  0x0000007f8dc12648
      iovisor#9  0x0000007f8dc0aef8
      iovisor#10 0x0000007f8dc1c990
      iovisor#11 0x0000007f8dc08b0c
      iovisor#12 0x0000007f8dc08e48
      iovisor#13 0x0000007f8dc081c8
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Mar 12, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#2  0xffffffc010084a08 el0_svc+0x8
      iovisor#3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#2  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#3  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#4  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#5  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#6  0xffffffc0100843b0 el0_da+0x1c
      iovisor#7  0xffffffc01027daa4 generic_copy_file_checks+0x334
      --
      iovisor#8  0x0000007f8dc12648 [unknown]
      iovisor#9  0x0000007f8dc0aef8 [unknown]
      iovisor#10 0x0000007f8dc1c990 [unknown]
      iovisor#11 0x0000007f8dc08b0c [unknown]
      iovisor#12 0x0000007f8dc08e48 [unknown]
      iovisor#13 0x0000007f8dc081c8 [unknown]
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Mar 17, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] [(MODULE+OFFSET)]

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#2  0xffffffc010084a08 el0_svc+0x8
      iovisor#3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#2  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#3  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#4  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#5  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#6  0xffffffc0100843b0 el0_da+0x1c
      iovisor#7  0xffffffc01027daa4 generic_copy_file_checks+0x334
      --
      iovisor#8  0x0000007f8dc12648 [unknown]
      iovisor#9  0x0000007f8dc0aef8 [unknown]
      iovisor#10 0x0000007f8dc1c990 [unknown]
      iovisor#11 0x0000007f8dc08b0c [unknown]
      iovisor#12 0x0000007f8dc08e48 [unknown]
      iovisor#13 0x0000007f8dc081c8 [unknown]
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Mar 17, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] [(MODULE+OFFSET)]

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#2  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#3  0xffffffc010084a08 el0_svc+0x8
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#2  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#3  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#4  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#5  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#6  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#7  0xffffffc0100843b0 el0_da+0x1c
      --
      iovisor#8  0x0000007f8dc12648 [unknown]
      iovisor#9  0x0000007f8dc0aef8 [unknown]
      iovisor#10 0x0000007f8dc1c990 [unknown]
      iovisor#11 0x0000007f8dc08b0c [unknown]
      iovisor#12 0x0000007f8dc08e48 [unknown]
      iovisor#13 0x0000007f8dc081c8 [unknown]
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Apr 4, 2022
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] [(MODULE+OFFSET)]

Print backtrace of ip if it failed to get syms.

Before:
  # profile -d
      psiginfo
      vscanf
      __snprintf_chk
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      [unknown]
      sd_event_exit
      sd_event_dispatch
      sd_event_run
      [unknown]
      __libc_start_main
      [unknown]
      -                systemd-journal (204)
          1

      xas_load
      xas_find
      filemap_map_pages
      __handle_mm_fault
      handle_mm_fault
      do_page_fault
      do_translation_fault
      do_mem_abort
      do_el0_ia_bp_hardening
      el0_ia
      xas_load
      --
  failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # profile -d
      #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#1  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
      iovisor#2  0xffffffc01009a93c el0_svc_handler+0x34
      iovisor#3  0xffffffc010084a08 el0_svc+0x8
      --
      iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
      iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
      iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
      iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
      iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
      iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
      iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
      -                fluent-bit (1238)
          1

      #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#1  0xffffffc01027daa4 generic_copy_file_checks+0x334
      iovisor#2  0xffffffc0102ba634 __handle_mm_fault+0x8dc
      iovisor#3  0xffffffc0102baa20 handle_mm_fault+0x168
      iovisor#4  0xffffffc010ad23c0 do_page_fault+0x148
      iovisor#5  0xffffffc010ad27c0 do_translation_fault+0xb0
      iovisor#6  0xffffffc0100816b0 do_mem_abort+0x50
      iovisor#7  0xffffffc0100843b0 el0_da+0x1c
      --
      iovisor#8  0x0000007f8dc12648 [unknown]
      iovisor#9  0x0000007f8dc0aef8 [unknown]
      iovisor#10 0x0000007f8dc1c990 [unknown]
      iovisor#11 0x0000007f8dc08b0c [unknown]
      iovisor#12 0x0000007f8dc08e48 [unknown]
      iovisor#13 0x0000007f8dc081c8 [unknown]
      -                PmLogCtl (2412)
          1

Signed-off-by: Eunseon Lee <[email protected]>
ekyooo added a commit to ekyooo/bcc that referenced this issue Oct 22, 2022
…for -v option

Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)

Print backtrace of ip if it failed to get syms.

Before:
  # offcputime -v
    psiginfo
    vscanf
    __snprintf_chk
    [unknown]
    [unknown]
    [unknown]
    [unknown]
    [unknown]
    sd_event_exit
    sd_event_dispatch
    sd_event_run
    [unknown]
    __libc_start_main
    [unknown]
    -                systemd-journal (204)
        1

    xas_load
    xas_find
    filemap_map_pages
    __handle_mm_fault
    handle_mm_fault
    do_page_fault
    do_translation_fault
    do_mem_abort
    do_el0_ia_bp_hardening
    el0_ia
    xas_load
    --
failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # offcputime -v
    #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
    iovisor#1  0xffffffc01009a93c el0_svc_handler+0x34
    iovisor#2  0xffffffc010084a08 el0_svc+0x8
    iovisor#3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
    --
    iovisor#4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
    iovisor#5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
    iovisor#6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
    iovisor#7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
    iovisor#8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
    iovisor#9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
    iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
    -                fluent-bit (1238)
        1

    #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
    iovisor#1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
    iovisor#2  0xffffffc0102baa20 handle_mm_fault+0x168
    iovisor#3  0xffffffc010ad23c0 do_page_fault+0x148
    iovisor#4  0xffffffc010ad27c0 do_translation_fault+0xb0
    iovisor#5  0xffffffc0100816b0 do_mem_abort+0x50
    iovisor#6  0xffffffc0100843b0 el0_da+0x1c
    iovisor#7  0xffffffc01027daa4 generic_copy_file_checks+0x334
    --
    iovisor#8  0x0000007f8dc12648 [unknown]
    iovisor#9  0x0000007f8dc0aef8 [unknown]
    iovisor#10 0x0000007f8dc1c990 [unknown]
    iovisor#11 0x0000007f8dc08b0c [unknown]
    iovisor#12 0x0000007f8dc08e48 [unknown]
    iovisor#13 0x0000007f8dc081c8 [unknown]
    -                PmLogCtl (2412)
        1

Fixed: iovisor#3884
Signed-off-by: Eunseon Lee <[email protected]>
yonghong-song pushed a commit that referenced this issue Oct 27, 2022
…for -v option

Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)

Print backtrace of ip if it failed to get syms.

Before:
  # offcputime -v
    psiginfo
    vscanf
    __snprintf_chk
    [unknown]
    [unknown]
    [unknown]
    [unknown]
    [unknown]
    sd_event_exit
    sd_event_dispatch
    sd_event_run
    [unknown]
    __libc_start_main
    [unknown]
    -                systemd-journal (204)
        1

    xas_load
    xas_find
    filemap_map_pages
    __handle_mm_fault
    handle_mm_fault
    do_page_fault
    do_translation_fault
    do_mem_abort
    do_el0_ia_bp_hardening
    el0_ia
    xas_load
    --
failed to get syms
      -                PmLogCtl (138757)
        1

After:
  # offcputime -v
    #0  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
    #1  0xffffffc01009a93c el0_svc_handler+0x34
    #2  0xffffffc010084a08 el0_svc+0x8
    #3  0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
    --
    #4  0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
    #5  0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
    #6  0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
    #7  0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
    #8  0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
    #9  0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
    #10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
    -                fluent-bit (1238)
        1

    #0  0xffffffc01027daa4 generic_copy_file_checks+0x334
    #1  0xffffffc0102ba634 __handle_mm_fault+0x8dc
    #2  0xffffffc0102baa20 handle_mm_fault+0x168
    #3  0xffffffc010ad23c0 do_page_fault+0x148
    #4  0xffffffc010ad27c0 do_translation_fault+0xb0
    #5  0xffffffc0100816b0 do_mem_abort+0x50
    #6  0xffffffc0100843b0 el0_da+0x1c
    #7  0xffffffc01027daa4 generic_copy_file_checks+0x334
    --
    #8  0x0000007f8dc12648 [unknown]
    #9  0x0000007f8dc0aef8 [unknown]
    #10 0x0000007f8dc1c990 [unknown]
    #11 0x0000007f8dc08b0c [unknown]
    #12 0x0000007f8dc08e48 [unknown]
    #13 0x0000007f8dc081c8 [unknown]
    -                PmLogCtl (2412)
        1

Fixed: #3884
Signed-off-by: Eunseon Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants