Skip to content

Commit

Permalink
offcputime: add the -d option
Browse files Browse the repository at this point in the history
Closes #559
  • Loading branch information
evverx committed Jun 7, 2016
1 parent f988644 commit 4509f09
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tools/offcputime.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def positive_nonzero_int(val):
help="show stacks from user space only (no kernel space stacks)")
stack_group.add_argument("-K", "--kernel-stacks-only", action="store_true",
help="show stacks from kernel space only (no user space stacks)")
parser.add_argument("-d", "--delimited", action="store_true",
help="insert delimiter between kernel/user stacks")
parser.add_argument("-f", "--folded", action="store_true",
help="output folded format")
parser.add_argument("--stack-storage-size", default=1024,
Expand Down Expand Up @@ -170,6 +172,8 @@ def signal_ignore(signal, frame):
bpf_text = bpf_text.replace('USER_STACK_GET', user_stack_get)
bpf_text = bpf_text.replace('KERNEL_STACK_GET', kernel_stack_get)

need_delimiter = args.delimited and not (args.kernel_stacks_only or args.user_stacks_only)

# check for an edge case; the code below will handle this case correctly
# but ultimately nothing will be displayed
if args.kernel_threads_only and args.user_stacks_only:
Expand Down Expand Up @@ -229,12 +233,15 @@ def signal_ignore(signal, frame):
kernel_stack = list(kernel_stack)
line = [k.name.decode()] + \
[b.sym(addr, k.pid) for addr in reversed(user_stack)] + \
(need_delimiter and ["-"] or []) + \
[b.ksym(addr) for addr in reversed(kernel_stack)]
print("%s %d" % (";".join(line), v.value))
else:
# print default multi-line stack output
for addr in kernel_stack:
print(" %016x %s" % (addr, b.ksym(addr)))
if need_delimiter:
print(" --")
for addr in user_stack:
print(" %016x %s" % (addr, b.sym(addr, k.pid)))
print(" %-16s %s (%d)" % ("-", k.name, k.pid))
Expand Down

0 comments on commit 4509f09

Please sign in to comment.