Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(indexer)!: add indexed id to fix implicit aliases and nfts #1075

Merged
merged 13 commits into from
Feb 1, 2023
Merged

fix(indexer)!: add indexed id to fix implicit aliases and nfts #1075

merged 13 commits into from
Feb 1, 2023

Conversation

DaughterOfMars
Copy link
Collaborator

@DaughterOfMars DaughterOfMars commented Jan 27, 2023 •
edited by Alex6323
Loading

Linked Issues

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

  • Test the indexer API endpoints.

INX Changes

  • Run chronicle using an INX connection.

Database Changes

  • Review database queries for correctness/conciseness.
  • Ensure queries are supported by indexes if needed.
  • Check for breaking changes in the data model and matching (conventional) commit message prefix.
  • Run the migration script.

grtlr
grtlr reviewed Jan 30, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
grtlr
grtlr previously approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the additional changes. LGTM, but still needs testing.

@DaughterOfMars DaughterOfMars mentioned this pull request Jan 31, 2023
Closed
grtlr
grtlr previously approved these changes Feb 1, 2023
View reviewed changes
@DaughterOfMars DaughterOfMars merged commit c37a5cb into main Feb 1, 2023
@DaughterOfMars DaughterOfMars deleted the fix/indexer/ids branch February 1, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outputs with implicit alias and NFT ids are not indexed correctly
3 participants
@DaughterOfMars @grtlr @Alex6323