Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ng-add schematic #20281

Merged
merged 2 commits into from
Jan 24, 2020
Merged

fix(angular): ng-add schematic #20281

merged 2 commits into from
Jan 24, 2020

Conversation

SchnWalter
Copy link
Contributor

@SchnWalter SchnWalter commented Jan 24, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The README.md instructs the user to link the invalid directory.
The npx schematics @ionic/angular:ng-add command generates an invalid angular.json. See my comment on the: 7af0198#r36943372

Issue Number: N/A

What is the new behavior?

  • The README.md instructs the user to link the ionic/angular/dist directory.
  • The npx schematics @ionic/angular:ng-add generates a valid angular.json file.

Does this introduce a breaking change?

  • Yes
  • No

cc: @mhartington

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants