fixes undefined group['node'] if missing from hosts.ini #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group_vars
,all.yml
There is no need for users to mess with the roles even for the
taint
functionality. The addition toextra_server_args
avoids duplication in files:roles/k3s/master/tasks/main.yml
androles/k3s/master/templates/k3s.service.j2
. For k3s anyway, taints are another extra server arg.Now even if a user wants to run for example, 3 master and 2 worker nodes with all of them being schedulable, they just have to delete the taint entry in
extra_server_args
variable.The new addition in
extra_server_args
:--tls-san {{ apiserver_endpoint }}
is mandatory, because the ip of our virtual ip needs to be in the SANs of the api server certificate, otherwise we cannot access our cluster.About testing and linting
In the ipv6 molecule test, because we override the
extra_server_args
, I added the 2 new entries:The rest of the changes were to make the linter happy, despite my commits had nothing to do with breaking the linter. I wonder if anyone could make any pull request without the linting action failing... ;-)
I think it is fixed even in a hacky way!
By the way I noticed intermittent failures in the metallb wait task in GitHub actions and I had to increase it to 120s. After that I had no failures.