Do not initialize the text in the editor using an undoable transaction

ioNihal · Mar 14, 2023 · d44ec86 · d44ec86
1 parent ba6ed6c
commit d44ec86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/codemirror.tsx b/src/components/codemirror.tsx
@@ -26,14 +26,14 @@ export default function CodeMirror(props: CodeMirrorProps) {
  if (!parent.current) throw new Error('Oh golly! The editor parent ref is null')
  let lastCode: string = props.initialCode ?? ''
  const editor = new EditorView({
- state: createEditorState(() => {
+ state: createEditorState(props.initialCode ? props.initialCode : "", () => {
  if (editor.state.doc.toString() === lastCode) return
  lastCode = editor.state.doc.toString()
  onCodeChangeRef.current?.()
  }, () => onRunShortcutRef.current?.()),
  parent: parent.current
  })
- if (props.initialCode) editor.dispatch({ changes: { from: 0, insert: props.initialCode } })
+
  props.onEditorView?.(editor)
  }, [])
 

diff --git a/src/lib/codemirror/init.ts b/src/lib/codemirror/init.ts
@@ -9,8 +9,9 @@ import { effect, signal } from '@preact/signals'
 import { h, render } from 'preact'
 import SearchBox from '../../components/search-box'
 
-export function createEditorState(onUpdate = () => {}, onRunShortcut = () => {}): EditorState {
+export function createEditorState(initialCode : string , onUpdate = () => {}, onRunShortcut = () => {}): EditorState {
  return EditorState.create({
+ doc:initialCode,
  extensions: [
  lineNumbers(),
  highlightActiveLineGutter(),