Enable rubocop; Bump version; Bump dependencies; Fix rubocop #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure example.rb reflects the code changes. Adjust wording (2nd factor requires a secret which is not reflected by the comments). With this change the order of username and password is technically irrelevant.
|
If you prefer the version bumping and rubocop introduction (and fixes due to it) in independent PRs let me know. I was chasing down the rabbit hole so... |
fabian-coder
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This PR provides a minimal rubocop config and fixes the gem to ruby versions 3.0 and higher. (<3.0 is EOL).
I also run a very basic rubocop check and adjusted all complaints to have a clean state.
This causes a required change (
set_debug(bool)toshow_debug(bool)) - if that's a bad change in your opinion, we can disable it in rubocop so it won't pop up. For this reason I've bumped to mayor 4.0 (breaking change).Also raised the dependencies to most current possible. Hope that fits.