Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for dynamic pages - Protein / Gene #8

Merged
merged 6 commits into from
Aug 13, 2019
Merged

Added support for dynamic pages - Protein / Gene #8

merged 6 commits into from
Aug 13, 2019

Conversation

akshatbhargava123
Copy link
Member

@akshatbhargava123 akshatbhargava123 commented Aug 10, 2019 •
edited
Loading

What's new?

  • Now conditionally checks what is being passed from BlueGenes (Protein / Gene) and conditionally does query
  • Added query for proteinId to protein (for primaryAccession)
  • Added test for the new query

Closes #7

@heralden
Copy link
Member

Could you add "Protein" to the classes array in config.json? Bluegenes needs this to know that it should also display the tool on the protein report page.

@akshatbhargava123
Copy link
Member Author

@uosl , added.

@heralden
Copy link
Member

Thanks, looks good!

@heralden heralden merged commit c3ca4c6 into intermine:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change visualization depending whether it is a Gene or a Protein page
2 participants
@akshatbhargava123 @heralden