Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Doc Replenish at go version && dlrover cmd #956

Merged

Conversation

SchopenhauerZhang
Copy link
Contributor

@SchopenhauerZhang SchopenhauerZhang commented Jan 16, 2024

##955

1、examples/pytorch/mnist/elastic_debug_job.yaml chang to examples/pytorch/mnist/elastic_job.yaml;
elastic_debug_job.yaml not exist!
2、go at least 1.18 or later

$ make deploy IMG=easydl/elasticjob-controller:master
/root/dlrover-0.3.1/dlrover/go/operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Error: err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy
$ go mod tidy
go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17

so go at least 1.18 ; like go 1.21.

bugfix dir path not corect
1、examples/pytorch/mnist/elastic_debug_job.yaml chang to examples/pytorch/mnist/elastic_job.yaml;
elastic_debug_job.yaml not exist!
2、go at least 1.18 or later

```
$ make deploy IMG=easydl/elasticjob-controller:master
/root/dlrover-0.3.1/dlrover/go/operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Error: err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy
$ go mod tidy
go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17
```
so go at least 1.18 ; like go 1.21.
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65478b9) 78.73% compared to head (4253528) 78.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
- Coverage   78.73%   78.71%   -0.02%     
==========================================
  Files         180      180              
  Lines       16313    16313              
==========================================
- Hits        12844    12841       -3     
- Misses       3469     3472       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@workingloong workingloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your modification!

@workingloong workingloong merged commit 94d58cc into intelligent-machine-learning:master Jan 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants