Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve training port conflict avoid #1181

Conversation

samplise
Copy link
Collaborator

@samplise samplise commented Jul 8, 2024

What changes were proposed in this pull request?

We can configure the start port of the training job.

Why are the changes needed?

  1. It is more efficient to configure the start training port when the users know the available port range.
  2. We can disable the port conflict-avoiding function.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (672a228) to head (8e8ce1c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
+ Coverage   79.72%   79.73%   +0.01%     
==========================================
  Files         210      210              
  Lines       18805    18812       +7     
==========================================
+ Hits        14992    15000       +8     
+ Misses       3813     3812       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@majieyue majieyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use training_port as a switch, LGTM~

Copy link
Collaborator

@BalaBalaYi BalaBalaYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalaBalaYi BalaBalaYi merged commit 40dc735 into intelligent-machine-learning:master Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants