The agent joins the rendzvous with the node id. #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 79.61% 79.65% +0.03%
==========================================
Files 210 210
Lines 18644 18681 +37
==========================================
+ Hits 14844 14880 +36
- Misses 3800 3801 +1 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
reviewed
Jun 25, 2024
BalaBalaYi
merged commit 0c18cc5
into
intelligent-machine-learning:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There may be nodes with different id and one rank to join the rendzvous.
Why are the changes needed?
The master may remove the relaunched node from the waiting nodes of rendzvous if the event of failed node arrives after a long latency time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.