Modify the controller's resource allocation settings. #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay experience instability when deployed in the cluster.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
=======================================
Coverage 79.61% 79.61%
=======================================
Files 210 210
Lines 18644 18644
=======================================
Hits 14844 14844
Misses 3800 3800 ☔ View full report in Codecov by Sentry. |
| @@ -66,10 +66,10 @@ spec: | |||
| resources: | |||
| limits: | |||
| cpu: 500m | |||
| memory: 128Mi | |||
| memory: 4090Mi | |||
There was a problem hiding this comment.
The memory is too large if we deploy the controller in a minikube cluster.
linkerzhang
reviewed
Jun 27, 2024
| @@ -141,7 +141,7 @@ class LockAcquireResponse(SocketResponse): | |||
| A response to acquire a shared lock using local socket. | |||
|
|
|||
| Attributes: | |||
| acquired (bool): Ture if the lock is acquired. | |||
| acquired (bool): True if the lock is acquired. | |||
There was a problem hiding this comment.
please move all these kind of "wording" changes / fixes into a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I modified the controller's resource allocation settings, with help from @Antlera
And... I fixed some TYPO during reading codes.
Why are the changes needed?
Otherwise, it will experience instability when deployed in the cluster.
Does this PR introduce any user-facing change?
Nope.
How was this patch tested?
Nope.