Fix request spelling error and add socket resource release #1165
Conversation
| @@ -242,26 +249,35 @@ def __init__(self, name="", create=False): | |||
| else: | |||
| self._lock = None | |||
|
|
|||
| def deal_client_msg(self, connection): | |||
There was a problem hiding this comment.
deal_client_msg -> _deal_client_msg which is a private method.
| @@ -471,28 +497,38 @@ def __init__(self, name="", create=False): | |||
| name=f"shard_dict_{name}", create=self._create | |||
| ) | |||
|
|
|||
| def deal_client_msg(self, connection): | |||
There was a problem hiding this comment.
There are 3 methods with the same name deal_client_msg. We can rename them as
_deal_shared_lock_msg
_deal_shared_queue_msg
_deal_shared_dict_msg
| try: | ||
| self.deal_client_msg(connection) | ||
| finally: | ||
| # 确保连接被关闭 |
There was a problem hiding this comment.
Please use English annotations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
- Coverage 79.61% 79.61% -0.01%
==========================================
Files 210 210
Lines 18644 18672 +28
==========================================
+ Hits 14844 14866 +22
- Misses 3800 3806 +6 ☔ View full report in Codecov by Sentry. |
|
You need to run pre-commit to check the code style before submitting a PR by the tutorial. https://github.com/intelligent-machine-learning/dlrover/blob/master/docs/developer_guide.md#submit-a-pr |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No feeling.
How was this patch tested?
Run unit test in dlrover/trainer/tests/torch/*_test.py.