Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize svc operation #1163

Conversation

BalaBalaYi
Copy link
Collaborator

@BalaBalaYi BalaBalaYi commented Jun 19, 2024

What changes were proposed in this pull request?

  1. set default port name in port spec: would fail if port name is none when doing patch operation
  2. support patch skipping: no need to patch svc if selector is the same

Why are the changes needed?

To enhance svc operation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (e0e095f) to head (26ffe2a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   79.59%   79.61%   +0.02%     
==========================================
  Files         210      210              
  Lines       18629    18644      +15     
==========================================
+ Hits        14828    14844      +16     
+ Misses       3801     3800       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Jun 19, 2024
@BalaBalaYi BalaBalaYi requested a review from cailun01 June 19, 2024 11:27
Copy link
Collaborator

@cailun01 cailun01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nash635 nash635 merged commit c2cc6d9 into intelligent-machine-learning:master Jun 19, 2024
12 checks passed
@BalaBalaYi BalaBalaYi changed the title optimize svs operation optimize svc operation Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants