Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wait in service check #1161

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

To fixed unexpected service check fail.

Why are the changes needed?

Service creation need time. So instant check is not suitable.

Does this PR introduce any user-facing change?

Nope.

How was this patch tested?

UT.

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (7fca2ba) to head (3a94a55).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         210      210              
  Lines       18629    18629              
==========================================
+ Hits        14823    14828       +5     
+ Misses       3806     3801       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalaBalaYi BalaBalaYi merged commit e0e095f into intelligent-machine-learning:master Jun 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants