Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Go version 1.18 in the docs. #1134

Conversation

workingloong
Copy link
Collaborator

What changes were proposed in this pull request?

List Go version 1.18 in the docs to deploy ElasticJob.

Why are the changes needed?

Make deploy with go1.22 raises errors.

/Users/yuzhi.wx/work/dlrover/dlrover/go/operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104c88cb4]

goroutine 27 [running]:
go/types.(*Checker).handleBailout(0x140000cf600, 0x140016a5d18)
	/usr/local/go/src/go/types/check.go:367 +0x9c
panic({0x104f53a60?, 0x1054dbf30?})
	/usr/local/go/src/runtime/panic.go:770 +0x124
go/types.(*StdSizes).Sizeof(0x0, {0x10501cc70, 0x1054e47c0})
	/usr/local/go/src/go/types/sizes.go:228 +0x314
go/types.(*Config).sizeof(...)
	/usr/local/go/src/go/types/sizes.go:333
go/types.representableConst.func1({0x10501cc70?, 0x1054e47c0?})
	/usr/local/go/src/go/types/const.go:76 +0x9c

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not code and just a doc.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (bdd8736) to head (b6bdfd6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   79.35%   79.35%           
=======================================
  Files         208      208           
  Lines       18335    18335           
=======================================
  Hits        14550    14550           
  Misses       3785     3785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BalaBalaYi BalaBalaYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@workingloong workingloong merged commit 77977a7 into intelligent-machine-learning:master May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants