Skip to content

Commit

Permalink
use private method and english annotation
Browse files Browse the repository at this point in the history
  • Loading branch information
yangrudan committed Jun 25, 2024
1 parent ae2de56 commit 8f3c3e4
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions dlrover/python/common/multi_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def __init__(self, name="", create=False):
else:
self._lock = None

def deal_client_msg(self, connection):
def _deal_shared_lock_msg(self, connection):
try:
recv_data = _socket_recv(connection)
msg: SocketRequest = pickle.loads(recv_data)
Expand All @@ -273,7 +273,7 @@ def _sync(self):
try:
connection, _ = self._server.accept()
try:
self.deal_client_msg(connection)
self._deal_shared_lock_msg(connection)
finally:
connection.close()
except Exception as e:
Expand Down Expand Up @@ -379,7 +379,7 @@ def __init__(self, name="", create=False, maxsize=1):
else:
self._queue = None

def deal_client_msg(self, connection):
def _deal_shared_queue_msg(self, connection):
try:
rcv_data = _socket_recv(connection)
msg: SocketRequest = pickle.loads(rcv_data)
Expand Down Expand Up @@ -408,7 +408,7 @@ def _sync(self):
try:
connection, _ = self._server.accept()
try:
self.deal_client_msg(connection)
self._deal_shared_queue_msg(connection)
finally:
connection.close()
except Exception as e:
Expand Down Expand Up @@ -497,7 +497,7 @@ def __init__(self, name="", create=False):
name=f"shard_dict_{name}", create=self._create
)

def deal_client_msg(self, connection):
def _deal_shared_dict_msg(self, connection):
try:
rcv_data = _socket_recv(connection)
msg: SocketRequest = pickle.loads(rcv_data)
Expand All @@ -523,9 +523,9 @@ def _sync(self):
try:
connection, _ = self._server.accept()
try:
self.deal_client_msg(connection)
self._deal_shared_dict_msg(connection)
finally:
# 确保连接被关闭
# Make sure the connection is closed
connection.close()
except Exception as e:
logger.error(f"An error in SharedDict occurred: {e}")
Expand Down

0 comments on commit 8f3c3e4

Please sign in to comment.