Fix PMU for UNC_CLOCK.SOCKET on BDW, HSW, SKL #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PMU uncore_clock isn't present on Skylake and earlier machines. The event is present on cbox_0 (note, the suffix is included to avoid multiple cbox PMUs being added together).
Yes, it's INTEL_UNCORE_EVENT_DESC(clockticks, "event=0xff,umask=0x00"), in the uncore driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PMU uncore_clock isn't present on Skylake and earlier machines. The event is present on cbox_0 (note, the suffix is included to avoid multiple cbox PMUs being added together).
Note, are the event encodings for BDW/HDW/SKL cbox_0 correct in this context? The json shows:
"EventCode": "0x0",
"UMask": "0x01",
but this maybe should be "event=0xff,umask=0x00". As uncore_clock isn't present on these models perf currently doesn't report this event.