Follow FIPS 203, not FIPS 204 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIPS 204 is ML-DSA. This crate implements FIPS 203 (ML-KEM), which is a different standard.
|
meh, it looks like this crate has been superseded by https://github.com/integritychain/fips203, where this issue is already fixed. please disregard this report. (maybe update the README here to point to that crate)? |
|
Yes, will do - sorry for the confusion - 203/204/205 are all in flight and should stabilize soon. (will change up README) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS 204 is ML-DSA. This crate implements FIPS 203 (ML-KEM), which is a different standard.