Update [email protected] #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=========================================
+ Coverage 98.49% 98.5% +<.01%
=========================================
Files 93 93
Lines 1395 1401 +6
Branches 171 171
=========================================
+ Hits 1374 1380 +6
Misses 20 20
Partials 1 1 |
wilhelmklopp
approved these changes
Mar 30, 2018
| core.text = mrkdwn(this.abstractIssue.body_html); | ||
| const { text, image } = mrkdwn(this.abstractIssue.body_html); | ||
| core.text = text; | ||
| core.image_url = image; |
There was a problem hiding this comment.
do we need a conditional here in case there is no image? I suppose Slack is fine with us passing image_url: undefined?
There was a problem hiding this comment.
JSON.stringify actually strips keys with undefined values:
$ node
> JSON.stringify({foo: undefined})
'{}'
| if (this.comment.body_html) { | ||
| const { text, image } = mrkdwn(this.comment.body_html); | ||
| baseMessage.text = text; | ||
| baseMessage.image_url = image; |
|
👍 added tests and updated snappydoo for the new tests. |
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=========================================
+ Coverage 98.49% 98.5% +<.01%
=========================================
Files 93 93
Lines 1395 1401 +6
Branches 171 171
=========================================
+ Hits 1374 1380 +6
Misses 20 20
Partials 1 1 |
This was referenced Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements: