Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive headers need a newline between them #21

Closed
devrelm opened this issue Jun 15, 2018 · 0 comments
Closed

Consecutive headers need a newline between them #21

devrelm opened this issue Jun 15, 2018 · 0 comments

Comments

@devrelm
Copy link
Contributor

devrelm commented Jun 15, 2018

When creating a Release on GitHub with two headers in the description like so:

## Released

### Changed

the /integrations/slack integration created a slack post like this:

image

My guess is that the markdown is being converted to an <h2> and <h3> with no space between them, and that html-to-mrkdwn is not going out of its way to add a newline back.

Because the <h1> through <h6> tags default to display: block, they naturally stack when viewed in a browser. As such, the expected behavior should be that headers – once converted – always begin and end with a newline.

devrelm added a commit to devrelm/html-to-mrkdwn that referenced this issue Jun 15, 2018
bkeepers added a commit that referenced this issue Jun 15, 2018
[Fixes #21] - Add newline before & after headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant