fix: expose private API on private port #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 2 2
Lines 76 76
=======================================
Hits 73 73
Misses 2 2
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0-alpha](v0.1.0-alpha...v0.2.0-alpha) (2024-04-02) ### Features * add CreateRepositoryTag endpoint ([#8](#8)) ([61bc325](61bc325)) * aggregate tag list with database info ([#7](#7)) ([6cc2d8d](6cc2d8d)) * create artifact database if it does not exist ([#4](#4)) ([787a4ad](787a4ad)) * fetch repository tags from registry ([#6](#6)) ([3568735](3568735)) ### Bug Fixes * expose private API on private port ([#9](#9)) ([9ef4b03](9ef4b03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Notes
Other services listen and serve both the public and the private API through the grpc-gateway. In the case of this service this isn't needed for the private API as it doesn't expose any HTTP endpoints (other services don't need to, either, but it's already exposed). Therefore, the "listen and serve" strategy is a bit different. The gRPC config should already contain the TLS information, if present, so we don't need an if/else block for the private API.