Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return pagination in tag list endpoint #17

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: return pagination in tag list endpoint #17

merged 1 commit into from
Apr 24, 2024

Conversation

jvallesm
Copy link
Collaborator

Because

  • Pagination metadata is missing in tag list endpoint.

This commit

  • Returns the requested page size and index and the total tag count.

@jvallesm jvallesm self-assigned this Apr 23, 2024
@jvallesm jvallesm marked this pull request as ready for review April 23, 2024 10:22
@jvallesm jvallesm requested a review from heiruwu April 23, 2024 10:22
@jvallesm jvallesm merged commit 72bc47a into main Apr 24, 2024
10 checks passed
@jvallesm jvallesm deleted the fix/jvalles-artifact-pagination branch April 24, 2024 05:38
@droplet-bot droplet-bot mentioned this pull request Apr 16, 2024
Merged
heiruwu pushed a commit that referenced this pull request Jun 6, 2024
@droplet-bot @Yougigun @pinglin
chore(main): release 0.3.0-alpha (#15)
c57330c 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0-alpha](v0.2.1-alpha...v0.3.0-alpha)
(2024-06-06)


### Features

* **kb:** knowldge base crud endpoints
([#19](#19))
([0e9f32b](0e9f32b))
* **kb:** knowledge base repository done
([#18](#18))
([f6aeaae](f6aeaae))
* use dind in Dockerfile
([#14](#14))
([d95aa68](d95aa68))


### Bug Fixes

* return pagination in tag list endpoint
([#17](#17))
([72bc47a](72bc47a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: gary.y <[email protected]>
Co-authored-by: Ping-Lin Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu heiruwu approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees

@jvallesm jvallesm

Labels
instill core
Projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
3 participants
@jvallesm @heiruwu @droplet-bot