Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kb): knowledge base repository done #18

Merged
merged 8 commits into from
May 30, 2024
Merged

feat(kb): knowledge base repository done #18

merged 8 commits into from
May 30, 2024

Conversation

Yougigun
Copy link
Collaborator

Because

we need knowledge base api.

This commit
is partial implementation for

  1. fix service and repository dependency tanggled
  2. create migration
  3. impl knowledge base related db operation
  4. make run-local and make build-local for local development

donch1989
donch1989 requested changes May 30, 2024
View reviewed changes
pkg/repository/knowledgebase.go Outdated Show resolved Hide resolved
@Yougigun Yougigun requested a review from donch1989 May 30, 2024 04:16
@Yougigun Yougigun requested a review from donch1989 May 30, 2024 07:28
donch1989
donch1989 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yougigun
I think we still need some work to align the details with other backend services. I'll approve this first to make the POC faster. We can optimize this iteratively.

@Yougigun
Copy link
Collaborator Author

@Yougigun I think we still need some work to align the details with other backend services. I'll approve this first to make the POC faster. We can optimize this iteratively.

@donch1989
got it.

@Yougigun Yougigun merged commit f6aeaae into instill-ai:main May 30, 2024
7 checks passed
@droplet-bot droplet-bot mentioned this pull request May 30, 2024
Merged
heiruwu pushed a commit that referenced this pull request Jun 6, 2024
@droplet-bot @Yougigun @pinglin
chore(main): release 0.3.0-alpha (#15)
c57330c 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0-alpha](v0.2.1-alpha...v0.3.0-alpha)
(2024-06-06)


### Features

* **kb:** knowldge base crud endpoints
([#19](#19))
([0e9f32b](0e9f32b))
* **kb:** knowledge base repository done
([#18](#18))
([f6aeaae](f6aeaae))
* use dind in Dockerfile
([#14](#14))
([d95aa68](d95aa68))


### Bug Fixes

* return pagination in tag list endpoint
([#17](#17))
([72bc47a](72bc47a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: gary.y <[email protected]>
Co-authored-by: Ping-Lin Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
instill core
Projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
3 participants
@Yougigun @donch1989 @droplet-bot