Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): add server plugin to enable SSE streaming and enable endpoints and configuration #202

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

tillknuesting
Copy link
Contributor

@tillknuesting tillknuesting commented Jun 21, 2024

Because:

  • KrakenD does not naively support long-lived connections, such as SSE or any other form of streaming.

This commit:

  • implement a server plugin for KrakenD that intercepts HTTP requests for the SSE endpoint and connects to the backed-end to transmit data
  • adds endpoint and configuration to support streaming

…ints

Because:
- KrakenD does not natively support long-lived connections, such as SSE or any other form of streaming.

This commit:
-implement a server plugin for KrakenD that intercepts HTTP requests for the sse endpoint and connects to the backend to transmit data
- adds endpoint and configuration to support streaming
…ints

Because:
- KrakenD does not natively support long-lived connections, such as SSE or any other form of streaming.

This commit:
-implement a server plugin for KrakenD that intercepts HTTP requests for the sse endpoint and connects to the backend to transmit data
- adds endpoint and configuration to support streaming
…ints

Because:
- KrakenD does not natively support long-lived connections, such as SSE or any other form of streaming.

This commit:
-implement a server plugin for KrakenD that intercepts HTTP requests for the sse endpoint and connects to the backend to transmit data
- adds endpoint and configuration to support streaming
@tillknuesting
Copy link
Contributor Author

for reference here is the standalone PoC for the plugin: https://github.com/tillknuesting/krakend-streaming

config/share/settings-env/input_headers.json Outdated Show resolved Hide resolved
plugins/sse-streaming/main.go Outdated Show resolved Hide resolved
# Conflicts:
#	config/share/settings-env/input_headers.json
…ints

Because:
- KrakenD does not natively support long-lived connections, such as SSE or any other form of streaming.

This commit:
-implement a server plugin for KrakenD that intercepts HTTP requests for the sse endpoint and connects to the backend to transmit data
- adds endpoint and configuration to support streaming
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donch1989 donch1989 merged commit 7d41024 into instill-ai:main Jul 4, 2024
11 checks passed
heiruwu pushed a commit that referenced this pull request Jul 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-beta](v0.19.0-beta...v0.20.0-beta)
(2024-07-15)


### Features

* **cors:** allow Instill-Use-SSE header
([#209](#209))
([296740f](296740f))
* **vdp:** add server plugin to enable SSE streaming and enable
endpoints and configuration
([#202](#202))
([7d41024](7d41024))
* **vdp:** expose pipeline profile image endpoint
([#211](#211))
([006f016](006f016))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👋 Done
3 participants