Enforce the type Query
on InstaQLEntity and InstaQLResult
#524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Given a schema like:
messages, users, messages.creator = users.createdMessages
If you made a type in the 'first' level of your expansion:
TS would warn you. But as you went deeper, you would lose typesafety:
This is because we were really lax with how we typed
Query
.It used to be:
I updated this to be:
(And similar for the
Result
types)This ensures that as we expand our tree, we are constantly typechecking.
@dwwoelfel @nezaj