Update style-loader and disable inclusion of its HMR code in builds

insin · Oct 4, 2017 · 24926b6 · 24926b6
1 parent 516484b
commit 24926b6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,11 @@
+## Changed
+
+- `style-loader`'s new `hmr` option is set to `false` when creating builds to prevent inclusion of its HMR code.
+
+## Dependencies
+
+- style-loader: v0.18.2 → [v0.19.0](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md#0190-2017-10-03)
+
 # 0.19.0 / 2017-10-02
 
 ## Breaking Changes

diff --git a/package.json b/package.json
@@ -104,7 +104,7 @@
  "html-webpack-plugin": "2.30.1",
  "npm-install-webpack2-plugin": "5.0.1",
  "postcss-loader": "2.0.6",
- "style-loader": "0.18.2",
+ "style-loader": "0.19.0",
  "url-loader": "0.5.9",
  "webpack-dev-middleware": "1.12.0",
  "webpack-dev-server": "2.9.1",

diff --git a/src/createWebpackConfig.js b/src/createWebpackConfig.js
@@ -190,6 +190,10 @@ export function createStyleLoaders(
  let name = loaderConfigName(prefix)
  let styleLoader = createLoader(name('style'), {
  loader: require.resolve('style-loader'),
+ options: {
+ // Only enable style-loader HMR when we're serving a development build
+ hmr: Boolean(server),
+ }
  })
  let loaders = [
  createLoader(name('css'), {