Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to update fmt_fn after the ARD has been created #253

Closed
ddsjoberg opened this issue May 26, 2024 · 2 comments · Fixed by #315
Closed

Add function to update fmt_fn after the ARD has been created #253

ddsjoberg opened this issue May 26, 2024 · 2 comments · Fixed by #315
Milestone

Comments

@ddsjoberg
Copy link
Collaborator

In some function in cardx, we don't have fmt_fn arguments in the ard_*() function. It would be nice to have a function to easily/consistently update the formatting functions.

@ddsjoberg
Copy link
Collaborator Author

Maybe stat_label too?

@ddsjoberg
Copy link
Collaborator Author

Not a priority , but we're on board to make this happen in the future.

@ddsjoberg ddsjoberg added this to the v0.2.0 Release milestone Jun 17, 2024
@ddsjoberg ddsjoberg removed this from the v0.2.0 Release milestone Jul 1, 2024
@ddsjoberg ddsjoberg added this to the v0.3.0 milestone Jul 25, 2024
ddsjoberg added a commit that referenced this issue Sep 16, 2024
**What changes are proposed in this pull request?**
* Added functions `update_ard_fmt_fn()` and `update_ard_stat_label()` to
update an ARD's formatting function and statistic label, respectively.
(#253)

**Reference GitHub issue associated with pull request.** _e.g., 'closes
#<issue number>'_
closes #253


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [ ] If a bug was fixed, a unit test was added.
- [ ] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [ ] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [ ] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant