Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from torchtyping to jaxtyping #226

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Migrate from torchtyping to jaxtyping #226

merged 4 commits into from
Oct 30, 2023

Conversation

carschno
Copy link
Collaborator

@carschno carschno commented Oct 27, 2023 •
edited
Loading

Description

  • Migrate torchtyping to jaxtyping
  • Increase minimum Python version to 3.9 for jaxtyping compatibility
  • Increase maximum Python version to 3.12.

Related Issue

Closes #167

Type of Change

  • 🥂 Improvement (non-breaking change which improves an existing feature)

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've successfully run the style checks using make fix-style.
  • [ ] I've written tests for all new methods and classes that I created and successfully ran make test.
  • [ ] I've written the docstring in Google format for all the methods and classes that I used.

@carschno carschno changed the title Increase minimum Python version to 3.9. Migrate from torchtyping to jaxtyping Oct 27, 2023
@carschno
Copy link
Collaborator Author

carschno commented Oct 30, 2023 •
edited
Loading

Note: I used the torch.Tensor object instead of jaxtyping.Array because the latter depends on jax, as indicated in the jaxtype documentation.

@carschno carschno marked this pull request as ready for review October 30, 2023 11:51
@carschno carschno mentioned this pull request Oct 30, 2023
Closed
gsarti
gsarti approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@gsarti gsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Bumped the Python>3.9 condition in requirements.txt and requirements-dev.txt

@gsarti gsarti merged commit 33f6932 into inseq-team:main Oct 30, 2023
3 checks passed
@carschno carschno deleted the enhancement/jaxtyping_167 branch October 30, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsarti gsarti gsarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate torchtyping to jaxtyping
2 participants
@carschno @gsarti