-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding skin tone to emojis #4290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the skintone just stored locally btw? Would make more sense for it to be another db column in users imo, and then be retrieved from store.user
. That way, other people can also see the respective skin colors, which makes more sense if you ask me.
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.tsx
Outdated
Show resolved
Hide resolved
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.test.tsx
Outdated
Show resolved
Hide resolved
I thought the same about this. |
@mateo-ivc you could also consider changing the logic so the emoji is sent with the skin tone included, then it wouldn't need to be manually added afterwards |
This comment has been minimized.
This comment has been minimized.
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.test.tsx
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…umlr.io into mi/adding-skin-tone-to-emojis
This comment has been minimized.
This comment has been minimized.
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Note/NoteReactionList/NoteReactionBar/NoteReactionBar.test.tsx
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
src/components/Note/NoteReactionList/NoteReactionChipCondensed/NoteReactionChipCondensed.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The deployment to the dev cluster was successful. You can find the deployment here: https://4290.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: b7c0ff0 |
Description
In the boa rdsettings a user is able to select their prefered skin tone. But till now all emojis would use the default color.
Changelog
types/boardReaction
types/reaction
components/BoardReaction
components/BoardReactionMenu
components/NoteReactionBar
components/NoteReactionChip
components/NoteReactionChipCondensed
Checklist
(Optional) Visual Changes