Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding skin tone to emojis #4290

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Conversation

mateo-ivc
Copy link
Collaborator

Description

In the boa rdsettings a user is able to select their prefered skin tone. But till now all emojis would use the default color.

Changelog

types/boardReaction

  • changing map from <ReactionType, string> to <ReactionType, {string, boolean}> since not all emojis support skin tones

types/reaction

  • changing map from <ReactionType, string> to <ReactionType, {string, boolean}> since not all emojis support skin tones

components/BoardReaction

  • adding variable that includes then skin tone if its possible for a given emoji

components/BoardReactionMenu

  • adding variable that includes then skin tone if its possible for a given emoji

components/NoteReactionBar

  • adding variable that includes then skin tone if its possible for a given emoji

components/NoteReactionChip

  • adding variable that includes then skin tone if its possible for a given emoji

components/NoteReactionChipCondensed

  • displaying emoji with skin tone if possible

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the skintone just stored locally btw? Would make more sense for it to be another db column in users imo, and then be retrieved from store.user. That way, other people can also see the respective skin colors, which makes more sense if you ask me.

@mateo-ivc
Copy link
Collaborator Author

Why is the skintone just stored locally btw? Would make more sense for it to be another db column in users imo, and then be retrieved from store.user. That way, other people can also see the respective skin colors, which makes more sense if you ask me.

I thought the same about this.
Would definitely implement this

@Schwehn42
Copy link
Collaborator

I thought the same about this.
Would definitely implement this

@mateo-ivc you could also consider changing the logic so the emoji is sent with the skin tone included, then it wouldn't need to be manually added afterwards

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This comment has been minimized.

@mateo-ivc mateo-ivc enabled auto-merge July 9, 2024 13:23
@mateo-ivc mateo-ivc disabled auto-merge July 9, 2024 13:23

This comment has been minimized.

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4290.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-b7c0ff0

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-b7c0ff0

Copy link

octomind-dev bot commented Jul 11, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: b7c0ff0

@brandstetterm brandstetterm merged commit 8b6dc7d into main Jul 11, 2024
10 checks passed
@brandstetterm brandstetterm deleted the mi/adding-skin-tone-to-emojis branch July 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants