Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added postman and linting to makefile #4248

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

BenedictHomuth
Copy link
Collaborator

@BenedictHomuth BenedictHomuth commented Jun 21, 2024

Description

Added linting and postman command to makefile.
Also added a command for all tests under one command

Increased deployment health check tries to 5, since most often 4 tries were not enough time, for the DNS entries to be available.

Changelog

  • Added postman command
  • Added linting command
  • Added a command for all go tests / lints
  • Added one more retry to deployment health check

@BenedictHomuth BenedictHomuth self-assigned this Jun 21, 2024
@BenedictHomuth BenedictHomuth added the Review Needed This pull request is ready for review label Jun 21, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jun 25, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4248.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-d2dd4a6

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-d2dd4a6

Copy link

octomind-dev bot commented Jun 25, 2024

🐙 Octomind

Test Report: 12/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: d2dd4a6

@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 077fbb7 Jun 25, 2024
10 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/makefile-tests branch June 25, 2024 11:16
BenedictHomuth added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: Benedict Homuth <[email protected]>
Co-authored-by: Jakob Schwehn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants