-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to disable anonymous accounts #4188
Conversation
🐙 OctomindTest Report: 0/14 successful.
commit sha: 6f91c38 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: 0e9a808 |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # server/src/api/context.go # src/routes/LoginBoard/LoginBoard.tsx
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # server/src/api/context.go # server/src/api/router.go # server/src/main.go # src/store/action/view.ts
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment has been minimized.
This comment has been minimized.
The deployment to the dev cluster was successful. You can find the deployment here: https://4188.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: 0c0742d |
Co-authored-by: Mateo Ivankovic <[email protected]>
Description
This PR adds the option to disable anonymous accounts.
When disabled (either by using the CLI flag
disable-anonymous-login
or in theconfig.toml
), new instances of anonymous accounts cannot be created. Instead, only active providers (Google, Apple, etc.) can be used.In the frontend, the button is also grayed out (subject to change?)
Closes #4169.
Note: Already logged in acounts can be still used
Changelog
backend
main
disable-anonymous-login
and config entryrouter
AnonymousLoginDisabledContext
for route/login/anonymous
AnonymousLoginDisabledContext
disable-anonymous-login
, and throw error if falseinfo
frontend
disableAnonymousLogin
LoginBoard
Checklist
(Optional) Visual Changes