Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to disable anonymous accounts #4188

Merged
merged 21 commits into from
Jul 23, 2024
Merged

Conversation

Schwehn42
Copy link
Collaborator

@Schwehn42 Schwehn42 commented Jun 3, 2024

Description

This PR adds the option to disable anonymous accounts.
When disabled (either by using the CLI flag disable-anonymous-login or in the config.toml), new instances of anonymous accounts cannot be created. Instead, only active providers (Google, Apple, etc.) can be used.
In the frontend, the button is also grayed out (subject to change?)
Closes #4169.

Note: Already logged in acounts can be still used

Changelog

backend

  • main
    • Add CLI flag disable-anonymous-login and config entry
  • router
    • add flag to Server struct
    • use context AnonymousLoginDisabledContext for route /login/anonymous
  • AnonymousLoginDisabledContext
    • check flag disable-anonymous-login, and throw error if false
  • info
    • add to info struct

frontend

  • store
    • adjust info state to include disableAnonymousLogin
  • LoginBoard
    • conditionally gray out anon login form

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@Schwehn42 Schwehn42 self-assigned this Jun 3, 2024
Copy link

octomind-dev bot commented Jun 3, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 6f91c38

Copy link

octomind-dev bot commented Jun 3, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 0e9a808

@Schwehn42 Schwehn42 changed the title feat:option to disable anonymous accounts feat: option to disable anonymous accounts Jun 3, 2024

This comment has been minimized.

server/src/api/router.go Outdated Show resolved Hide resolved
@Schwehn42 Schwehn42 marked this pull request as ready for review June 17, 2024 09:31
@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jun 17, 2024
@inovex inovex deleted a comment from github-actions bot Jun 17, 2024
@inovex inovex deleted a comment from octomind-dev bot Jun 17, 2024

This comment has been minimized.

server/src/main.go Outdated Show resolved Hide resolved

This comment has been minimized.

# Conflicts:
#	server/src/api/context.go
#	server/src/api/router.go
#	server/src/main.go
#	src/store/action/view.ts

This comment has been minimized.

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

This comment has been minimized.

@Schwehn42 Schwehn42 enabled auto-merge July 23, 2024 13:10
@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jul 23, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4188.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-0c0742d

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-0c0742d

Copy link

octomind-dev bot commented Jul 23, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 0c0742d

@Schwehn42 Schwehn42 added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 80cdf94 Jul 23, 2024
12 checks passed
@Schwehn42 Schwehn42 deleted the js/disable-anonymous-login branch July 23, 2024 15:56
liza-kl pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable anonymous login
3 participants