-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Split the messaging channel between user and moderator/owner #4113
Conversation
🐙 OctomindTest Report: 0/14 successful.
commit sha: f7733ad |
🐙 OctomindTest Report: 0/14 successful.
commit sha: f7733ad |
🐙 OctomindTest Report: 6/14 successful.
commit sha: f7733ad |
🐙 OctomindTest Report: 6/14 successful.
commit sha: f7733ad |
🐙 OctomindTest Report: 6/14 successful.
commit sha: aeedb3d |
🐙 OctomindTest Report: 6/14 successful.
commit sha: afaf300 |
🐙 OctomindTest Report: 6/14 successful.
commit sha: 812fe4a |
I think I've noted it before, but I think it would be better if every user continued to have |
If we were to have the moderators subscribe to a second channel just for moderator information, we would have to write a new filter that removes the public data, or we would be sending the same information twice. |
Yeah, but the intention of the issue has been that the new moderator channel will be exclusively used for the information that normal participants shouldn't see afaik |
🐙 OctomindTest Report: 6/14 successful.
commit sha: 4a7b959 |
The deployment to the dev cluster was successful. You can find the deployment here: https://4113.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: 4a7b959 |
Description
Splitted up the board subscription into two channels. Prior every user subscribed to
boards.<boardID>
now based on the role each user connects toboards.<boardID>.participant
orboards.<boardID>.moderator
.Why? To avoid sending events to participants they don't have access to.
Changelog
api/boards_listen_on_board.go
event_filter.go
board_sessions_observer.go
database/columns.go
database/columns_observer.go
database/notes.go
database/notes_observer.go
realtime/boards.go
boards.<boardID>.moderator/participant
services/...
in order to send the event to the correct channel, it's necessary to check if the column is hidden or not.
services/boards/sessions.go
Checklist
(Optional) Visual Changes