feat: lock board #3955

brandstetterm · 2024-03-08T09:27:19Z

Description

Frontend changes related to the locking of a board. If a board is locked, participants (without moderation permissions) are no longer able to create, update and delete notes, dispatch board reactions, add or remove reactions to a note, add or remove votes to a note. Therefore, there have been some changes in the frontend (e.g. gray out buttons, hide buttons, etc.). A detailed list of the changes can be found below.

Closes #3538

Changelog

NoteInput: Disable textarea, add lock icon, gray out plus icon
StackView: Disable textarea to edit note content, hide delete and unstack buttons
Action Bars: Disable button to dispatch board reactions, automatically close board reactions menu if board gets locked
Notes: Hide button to open reactions dropdown, disable button to remove note reactions, hide button to add a vote and disable button to remove a vote
Update several tests and snapshots

Future tasks

Implement notifications manager and dispatch notification that board is locked on join

Visual changes

editing from redux store

input

octomind-dev · 2024-03-11T08:01:03Z

🐙 Octomind

Test Report: 10/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 2fffed9

moderator

octomind-dev · 2024-03-11T10:09:29Z

🐙 Octomind

Test Report: 12/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 7af6b86

octomind-dev · 2024-03-12T12:52:25Z

🐙 Octomind

Test Report: 11/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 7b6091e

octomind-dev · 2024-03-12T13:06:14Z

🐙 Octomind

Test Report: 11/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Failed ❌	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 315cf92

participants)

octomind-dev · 2024-03-12T13:36:33Z

🐙 Octomind

Test Report: 12/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: a18c165

octomind-dev · 2024-05-29T12:43:00Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Failed ❌	click
test all ways to open the setup flow	Failed ❌	click

commit sha: f353a3d

Schwehn42 · 2024-05-29T15:18:34Z

added feats: #4144 and #4145, ready to review now

# Conflicts: # src/components/MenuBars/MenuBars.tsx # src/components/Note/NoteReactionList/NoteReactionList.tsx # src/components/NoteInput/NoteInput.scss # src/components/NoteInput/NoteInput.tsx # src/components/TooltipButton/TooltipButton.scss

# Conflicts: # server/api.postman_collection.json # src/components/Note/NoteReactionList/NoteReactionChip/NoteReactionChip.tsx # src/components/Note/NoteReactionList/NoteReactionList.tsx # src/components/NoteInput/NoteInput.scss

BenedictHomuth · 2024-07-19T09:53:46Z

Should the feature of locking a board also be an option, when creating a board?
Meaning that it should be possible to set the "isLocked" field in the API request when creating a board?

If so I would add it. I do not remember if this was requested or not when we formulated this feature.

Schwehn42 · 2024-07-19T11:11:59Z

@BenedictHomuth

Should the feature of locking a board also be an option, when creating a board?

This isn't an AC in #3538, so I would hold on implementing it, since the create board screen will be overhauled soon anyways.

laila-rin

looks good to me, works well.

Would it make sense to have a little lock icon for the moderator also, so they know if the board is locked or not? Atm it's just the non-moderator participants that have a lock icon to indicate that, right?

Schwehn42 · 2024-07-19T14:11:10Z

@laila-rin Good point, I actually like the initial idea from the issue (#3538) where instead of toggle in board settings, it would be an button on the right where the rest of the moderator tools (start vote, start timer ...) are. That way, moderators could always see whether it's active, and also toggle it with one click instead of two.

What do you think about this? Also, does it make more sense to just use this version and make these changes in a new PR, if @SelinaBuff approves of the idea?

# Conflicts: # src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.tsx

github-actions · 2024-07-19T14:21:04Z

The deployment to the dev cluster was successful. You can find the deployment here: https://3955.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-d789bd8
ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-d789bd8

octomind-dev · 2024-07-19T14:21:49Z

🐙 Octomind

Test Report: 13/14 successful.

description	status	details
About Section Visibility Test	Passed ✅	click
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Passed ✅	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: d789bd8

brandstetterm added 4 commits March 7, 2024 17:05

Add simple component to lock the board in the quick menu

d57035c

Add allowEditing boolean to board type

039baeb

Set toggle value of lock board component to current value of allow

7196dc1

editing from redux store

Clicking on the lock board button dispatches api request

78b36a4

brandstetterm self-assigned this Mar 8, 2024

brandstetterm and others added 9 commits March 8, 2024 10:31

Merge branch 'main' into mb/lock-board

af1bc6f

Add board settings toggle to change the locking of a board

d876b3b

Add gap between different groups of board settings and change order

578785f

Update snapshots of board settings and header menu

f68d9ed

Translate label of board settings toggle

77d9dc7

Add translated labels to header menu toggle

b5c881f

Update snapshots of header menu and board settings

c4689a9

Change import order of lock board component

15e46ab

Grey out disabled buttons when board is locked and add lock icon to note

9fcd848

input

brandstetterm added 2 commits March 11, 2024 10:51

Disable the moving of notes for participants when the board is locked

b7b3eae

Hide note reactions when board is locked and participant is not

0b7da39

moderator

Resolve merge conflicts

2ff2f67

Merge branch 'main' into mb/lock-board

6e92701

brandstetterm added 3 commits March 12, 2024 14:15

Remove box shadow when noteinput is disabled (only for normal

82805ba

participants)

Only disable the menu bar items when the participant is not moderator

b3a6381

Disable textarea of note for participants

912ad67

brandstetterm added 4 commits March 12, 2024 15:33

Hide note reactions button for participants when board is locked

1d018ce

Disable button to remove own note reaction for non-moderator

c63f550

Gray out plus icon in noteinput if board is locked

7d5eb95

Remove margins from elements and add padding to noteinput

0ea5b5a

This comment has been minimized.

Sign in to view

Schwehn42 added the Review Needed This pull request is ready for review label May 29, 2024

Schwehn42 self-assigned this May 29, 2024

Schwehn42 mentioned this pull request May 30, 2024

Notify participants on join if a board is locked #4081

Open

Schwehn42 added 2 commits June 17, 2024 12:19

fix icon

2442722

This comment has been minimized.

Sign in to view

Schwehn42 added 2 commits June 26, 2024 11:43

Merge branch 'refs/heads/main' into mb/lock-board

37a6774

update collection

0ee90ed

This comment has been minimized.

Sign in to view

Schwehn42 added 4 commits July 16, 2024 16:32

Merge branch 'refs/heads/main' into mb/lock-board

fb12918

# Conflicts: # server/api.postman_collection.json # src/components/Note/NoteReactionList/NoteReactionChip/NoteReactionChip.tsx # src/components/Note/NoteReactionList/NoteReactionList.tsx # src/components/NoteInput/NoteInput.scss

increment migration file prefix

4fd9827

fix color names

e2c09d1

update postman collection

ff5043f

This comment has been minimized.

Sign in to view

laila-rin approved these changes Jul 19, 2024

View reviewed changes

Merge branch 'refs/heads/main' into mb/lock-board

b8f8712

# Conflicts: # src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.tsx

laila-rin approved these changes Jul 19, 2024

View reviewed changes

Schwehn42 removed the Review Needed This pull request is ready for review label Jul 19, 2024

Schwehn42 added this pull request to the merge queue Jul 19, 2024

Merged via the queue into main with commit 8bebd00 Jul 19, 2024
10 checks passed

Schwehn42 deleted the mb/lock-board branch July 19, 2024 15:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lock board #3955

feat: lock board #3955

brandstetterm commented Mar 8, 2024 •

edited

Loading

octomind-dev bot commented Mar 11, 2024 •

edited

Loading

octomind-dev bot commented Mar 11, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented May 29, 2024 •

edited

Loading

This comment has been minimized.

Schwehn42 commented May 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

BenedictHomuth commented Jul 19, 2024

Schwehn42 commented Jul 19, 2024

laila-rin left a comment

Schwehn42 commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

octomind-dev bot commented Jul 19, 2024 •

edited

Loading

feat: lock board #3955

feat: lock board #3955

Conversation

brandstetterm commented Mar 8, 2024 • edited Loading

Description

Changelog

Future tasks

Visual changes

octomind-dev bot commented Mar 11, 2024 • edited Loading

🐙 Octomind

octomind-dev bot commented Mar 11, 2024 • edited Loading

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited Loading

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited Loading

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited Loading

🐙 Octomind

octomind-dev bot commented May 29, 2024 • edited Loading

🐙 Octomind

This comment has been minimized.

Schwehn42 commented May 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

BenedictHomuth commented Jul 19, 2024

Schwehn42 commented Jul 19, 2024

laila-rin left a comment

Choose a reason for hiding this comment

Schwehn42 commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

octomind-dev bot commented Jul 19, 2024 • edited Loading

🐙 Octomind

brandstetterm commented Mar 8, 2024 •

edited

Loading

octomind-dev bot commented Mar 11, 2024 •

edited

Loading

octomind-dev bot commented Mar 11, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented Mar 12, 2024 •

edited

Loading

octomind-dev bot commented May 29, 2024 •

edited

Loading

octomind-dev bot commented Jul 19, 2024 •

edited

Loading