-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lock board #3955
feat: lock board #3955
Conversation
🐙 OctomindTest Report: 10/13 successful.
commit sha: 2fffed9 |
🐙 OctomindTest Report: 12/13 successful.
commit sha: 7af6b86 |
🐙 OctomindTest Report: 11/13 successful.
commit sha: 7b6091e |
🐙 OctomindTest Report: 11/13 successful.
commit sha: 315cf92 |
🐙 OctomindTest Report: 12/13 successful.
commit sha: a18c165 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: f353a3d |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/components/MenuBars/MenuBars.tsx # src/components/Note/NoteReactionList/NoteReactionList.tsx # src/components/NoteInput/NoteInput.scss # src/components/NoteInput/NoteInput.tsx # src/components/TooltipButton/TooltipButton.scss
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # server/api.postman_collection.json # src/components/Note/NoteReactionList/NoteReactionChip/NoteReactionChip.tsx # src/components/Note/NoteReactionList/NoteReactionList.tsx # src/components/NoteInput/NoteInput.scss
This comment has been minimized.
This comment has been minimized.
Should the feature of locking a board also be an option, when creating a board? If so I would add it. I do not remember if this was requested or not when we formulated this feature. |
This isn't an AC in #3538, so I would hold on implementing it, since the create board screen will be overhauled soon anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, works well.
Would it make sense to have a little lock icon for the moderator also, so they know if the board is locked or not? Atm it's just the non-moderator participants that have a lock icon to indicate that, right?
@laila-rin Good point, I actually like the initial idea from the issue (#3538) where instead of toggle in board settings, it would be an button on the right where the rest of the moderator tools (start vote, start timer ...) are. That way, moderators could always see whether it's active, and also toggle it with one click instead of two. What do you think about this? Also, does it make more sense to just use this version and make these changes in a new PR, if @SelinaBuff approves of the idea? |
# Conflicts: # src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.tsx
The deployment to the dev cluster was successful. You can find the deployment here: https://3955.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: d789bd8 |
Description
Frontend changes related to the locking of a board. If a board is locked, participants (without moderation permissions) are no longer able to create, update and delete notes, dispatch board reactions, add or remove reactions to a note, add or remove votes to a note. Therefore, there have been some changes in the frontend (e.g. gray out buttons, hide buttons, etc.). A detailed list of the changes can be found below.
Closes #3538
Changelog
Future tasks
Visual changes