Migrate to terraform 0.12.7 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johscheuer
suggested changes
Aug 28, 2019
Readme.md
Outdated
| The provided dockerfile set up a system with all required software. To deploy the training environment run: | ||
| ```bash | ||
| docker build -t lfs458-prep | ||
| docker run -it -v $(pwd):/wd -w /wd lfs458-prep |
There was a problem hiding this comment.
From my pov this is more work than just downloading the according binary and use it. If we use the official docker image IMHO this can work since we don't need anything else (except docker of course).
There was a problem hiding this comment.
Also I would add --rm since we only need an "ephemeral" container.
There was a problem hiding this comment.
Yes, for most people this is more work. Me included. However, I wanted to provide a stable environment for the terraform code and the create_package.sh script. Therefore the dockerfile include puttygen and zip.
|
PTAL |
johscheuer
reviewed
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.