Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add file and folder selection functionality #6

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

Francesco146
Copy link

@Francesco146 Francesco146 commented Jun 1, 2024

all the managers have broken the "Select file path" and "Select folder path" when editing the patch options, also if you put a valid path there it throws a PathNotFoundException

i made this as draft because i still need to find the lowest permissions that make the feature work. right now i managed to patch by selecting the folder from the UI and get the right permissions to read all the needed files. things left to make:

  • after the selection, the text box shows the path as a SAF content:https:// URL, this need to be changed with a /storage/emulated/0/... path (done in d475145)
  • lower permissions as much as possible (done in da28ffd)

ref: flutter/flutter#40498 (comment)

@inotia00

This comment was marked as outdated.

@Francesco146
Copy link
Author

i noticed that, I didn't have time to look deeply, so I removed the changes locally that were based on the modified patcher. glad you fixed that, I have in mind how to solve the first of the two still unsolved problems, tomorrow I'll do that :)

@Francesco146 Francesco146 marked this pull request as ready for review June 2, 2024 14:23
@Francesco146
Copy link
Author

Francesco146 commented Jun 2, 2024

i'm fairly certain that, because of the various processes untied during the patching phase, the minimum level of permissions to access files is this

edit: i can't think of a better name for this PR, change it if you need to

@Francesco146 Francesco146 changed the title fix: make Select file or Folder work feat: Add file and folder selection functionality Jun 2, 2024
@Francesco146
Copy link
Author

Francesco146 commented Jun 3, 2024

it's worth adding that the permissions request should only be needed on Android 10+ (need other testing), so it could only be asked if the device is in that category

@Francesco146
Copy link
Author

ready for review @inotia00 :)

@inotia00
Copy link
Owner

Thanks

@inotia00 inotia00 merged commit 36a3c8b into inotia00:main Jun 23, 2024
@Francesco146
Copy link
Author

Thanks to you as well

@Francesco146
Copy link
Author

@inotia00 you reverted this in the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants