Replace scrollHeight/scrollWidth with stored scrollSize #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inokawa
force-pushed
the
scroll-size-store
branch
from
f501eb5
to
6f20eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175
As described in mdn,
scrollHeightis rounded number butscrollTopandcontentRectfrom ResizeObserver has non-rounded number.Because of this difference, scrollSize which is used internally in this lib (calcurated from
contentRect) and scrollSize what users can get from handle (scrollHeight) can have different value if browser'swindow.devicePixelRatiohas decimal value (ex.1.5or1.25in Windows OS). That makes it harder to implement at-bottom detection logic in userland.So this PR will replace scrollHeight usages with stored scrollSize. scrollHeight was necessary in early implementation of scrollToIndex but it seems that it's not now.