Improve automatic item size estimation #373
Merged
+152
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inokawa
force-pushed
the
fix-estimate-size
branch
9 times, most recently
from
af1fcfa
to
9658ebb
Compare
inokawa
changed the title
inokawa
force-pushed
the
fix-estimate-size
branch
2 times, most recently
from
ccf4d9a
to
7577ca8
Compare
inokawa
force-pushed
the
fix-estimate-size
branch
from
7577ca8
to
99015cc
Compare
inokawa
force-pushed
the
fix-estimate-size
branch
from
99015cc
to
fa8c095
Compare
takecchi
pushed a commit
to cuculus-dev/cuculus
that referenced
this pull request
Feb 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [virtua](https://togithub.com/inokawa/virtua) | [`0.25.0` -> `0.26.0`](https://renovatebot.com/diffs/npm/virtua/0.25.0/0.26.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | @coderabbitai: ignore --- ### Release Notes <details> <summary>inokawa/virtua (virtua)</summary> ### [`v0.26.0`](https://togithub.com/inokawa/virtua/releases/tag/0.26.0) [Compare Source](https://togithub.com/inokawa/virtua/compare/0.25.0...0.26.0) - **BREAKING CHANGE**: `reverse` prop was removed from `Virtualizer` - You can achieve the same effect by writing small CSS and using `scrollRef` prop of `Virtualizer` https://github.com/inokawa/virtua/blob/44f5f1b7d56f9734b4e3c56809c062adf9d2e5a4/src/react/VList.tsx#L92-L95 - Or you can continue to use `reverse` prop of `VList`. #### What's Changed - Remove min-height/min-width from container by [@​inokawa](https://togithub.com/inokawa) in [inokawa/virtua#359 - Improve automatic item size estimation by [@​inokawa](https://togithub.com/inokawa) in [inokawa/virtua#373 - Refactor jump calculation by [@​inokawa](https://togithub.com/inokawa) in [inokawa/virtua#363 - Optimize Vue Virtualizer with [@​vue/babel-plugin-jsx](https://togithub.com/vue/babel-plugin-jsx) by [@​inokawa](https://togithub.com/inokawa) in [inokawa/virtua#374 **Full Changelog**: inokawa/virtua@0.25.0...0.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cuculus-dev/cuculus). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #371
fix #15
The previous logic didn't work correctly with reverse scrolling, but it's now fixed.