Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdm translate flattened_gtest_results breaks make #45

Open
hshuaib90 opened this issue Feb 15, 2020 · 7 comments
Open

rdm translate flattened_gtest_results breaks make #45

hshuaib90 opened this issue Feb 15, 2020 · 7 comments

Comments

@hshuaib90
Copy link

When running rdm translate on xunit-style results, the flattened_gtest_results doesn't pick up req_ids (I'm not sure how it would?) and therefore when I go to make my documents, I get the following error:

File "./documents/test_record.md", line 36, in block "test_results" | {{ test_name }} | {{ unit_test_record[test_name].result }} | {{ unit_test_record[test_name].req_ids }} | {% if unit_test_record[test_name].note is defined %}{{ unit_test_record[test_name].note }}{% endif %} | jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'req_ids'

How would you plan to include req_ids from translate output? I use pytest for my python code and that provides the record_property fixture which can be used to inject into the XML report, which can then be picked up by translate.

@johndgiese
Copy link
Contributor

@hshuaib90 this is a great question! At the moment, we have not agreed on the best approach to solving this problem. On our own projects, I believe we have thus far entered the req_ids manually. This is certainly not ideal!

Thank you for creating an issue for this. How has your experience with RDM been so far? Let us know if you have any other questions or comments. We are slowly improving it as we have used it on our own projects.

@johndgiese
Copy link
Contributor

(@orwonthe may be able to comment further)

@hshuaib90
Copy link
Author

Thanks for the response @johndgiese ! I have only just started investigating RDM and am exploring using it as part of our EU-MDR compliance in our institution.

Are you looking to solve this issue internally or are you open to external PRs to solve this?

@johndgiese
Copy link
Contributor

@hshuaib90 if you have any ideas about how you would want this issue to be solved, we would love to hear them. A PR may be helpful too, but perhaps only after discussing the problem further and arriving at some consensus for the approach.

@johndgiese
Copy link
Contributor

@hshuaib90 did you guys end up using RDM? Any thoughts or suggestions for how we can improve it?

@hshuaib90
Copy link
Author

hshuaib90 commented Oct 13, 2020 via email

@johndgiese
Copy link
Contributor

@hshuaib90 thank you for the response. Candid feedback will help prevent us from fitting RDM too closely to Innolitics' workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants