Skip to content

Commit

Permalink
Use correct boolean values
Browse files Browse the repository at this point in the history
  • Loading branch information
slarew authored and staticfloat committed Apr 16, 2019
1 parent 05c2ead commit d1586bf
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions contrib/mac/frameworkapp/ExecSandbox/ExecSandbox.m
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ - (void)eval:(NSString *)p
[[NSProcessInfo processInfo] globallyUniqueString];
NSURL *temporaryFileURL =
[temporaryDirectoryURL URLByAppendingPathComponent:temporaryFilename
isDirectory:false];
isDirectory:NO];

[[p dataUsingEncoding:NSUTF8StringEncoding] writeToURL:temporaryFileURL
atomically:false];
atomically:NO];

NSMutableArray<NSString *> *args = [[NSMutableArray alloc] init];
[args addObjectsFromArray:baseArgs];
Expand Down
20 changes: 10 additions & 10 deletions contrib/mac/frameworkapp/JuliaLauncher/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ - (instancetype)initWithJulia:(NSURL *)exe bundle:(NSBundle *)b {
relativeToURL:nil
error:nil];

_updatingVersion = true;
_updatingVersion = YES;

id<ExecSandboxProtocol> remote = [[ExecSandboxController sharedController]
remoteObjectProxyWithErrorHandler:^(NSError *error) {
[self willChangeValueForKey:@"updatingVersion"];
self->_updatingVersion = false;
self->_updatingVersion = NO;
[self didChangeValueForKey:@"updatingVersion"];
}];

Expand All @@ -118,13 +118,13 @@ - (instancetype)initWithJulia:(NSURL *)exe bundle:(NSBundle *)b {
[self willChangeValueForKey:@"version"];
[self willChangeValueForKey:@"updatingVersion"];
self->_version = vout;
self->_updatingVersion = false;
self->_updatingVersion = NO;
[self didChangeValueForKey:@"updatingVersion"];
[self didChangeValueForKey:@"version"];

} else {
[self willChangeValueForKey:@"updatingVersion"];
self->_updatingVersion = false;
self->_updatingVersion = NO;
[self didChangeValueForKey:@"updatingVersion"];
}
}];
Expand Down Expand Up @@ -241,22 +241,22 @@ - (void)findJuliaQueryDidUpdate:(NSNotification *)sender {
// TODO: Verify the executable is actually a Julia.
NSURL *juliaexe =
[[[NSURL alloc] initFileURLWithPath:itemPath
isDirectory:false] URLByStandardizingPath];
isDirectory:NO] URLByStandardizingPath];
NSLog(@"Found Julia %@", juliaexe);
JuliaVariant *jv = [[JuliaVariant alloc] initWithJulia:juliaexe
bundle:nil];
[self addJuliaVariant:jv];
} else if ([contentType isEqual:@"com.apple.framework"]) {
NSURL *frameworkPath = [[NSURL alloc] initFileURLWithPath:itemPath
isDirectory:true];
isDirectory:YES];
NSLog(@"Found Julia framework %@", frameworkPath);

// Iterate over versions within the framework.

NSFileManager *fm = NSFileManager.defaultManager;
NSURL *frameworkVersions =
[frameworkPath URLByAppendingPathComponent:@"Versions"
isDirectory:true];
isDirectory:YES];
NSArray<NSURL *> *versions =
[fm contentsOfDirectoryAtURL:frameworkVersions
includingPropertiesForKeys:@[ NSURLIsDirectoryKey ]
Expand All @@ -279,9 +279,9 @@ - (void)findJuliaQueryDidUpdate:(NSNotification *)sender {
NSURL *juliaexe = [[[[bundle.executableURL URLByStandardizingPath]
URLByDeletingLastPathComponent]
URLByAppendingPathComponent:@"Helpers"
isDirectory:true]
isDirectory:YES]
URLByAppendingPathComponent:@"julia"
isDirectory:false];
isDirectory:NO];

if (juliaexe == nil) {
continue;
Expand Down Expand Up @@ -430,7 +430,7 @@ void execJuliaInTerminal(NSURL *_Nonnull julia) {

do {
s = AEDeterminePermissionToAutomateTarget(
aedTarget.aeDesc, aevShellCmd.eventClass, aevShellCmd.eventID, true);
aedTarget.aeDesc, aevShellCmd.eventClass, aevShellCmd.eventID, TRUE);
retry = s == procNotFound && !retry && launchTerminalApp();
} while (retry);

Expand Down

0 comments on commit d1586bf

Please sign in to comment.