Make show_function() use var""-syntax to escape names (JuliaLang#38418)

Without this, the result of `show()` is not valid, interpretable julia.
inkydragon · Nov 13, 2020 · 9ecc1f2 · 9ecc1f2
1 parent 13aac25
commit 9ecc1f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/base/show.jl b/base/show.jl
@@ -454,9 +454,10 @@ function show_function(io::IO, f::Function, compact::Bool)
  elseif isdefined(mt, :module) && isdefined(mt.module, mt.name) &&
  getfield(mt.module, mt.name) === f
  if is_exported_from_stdlib(mt.name, mt.module) || mt.module === Main
- print(io, mt.name)
+ show_sym(io, mt.name)
  else
- print(io, mt.module, ".", mt.name)
+ print(io, mt.module, ".")
+ show_sym(io, mt.name)
  end
  else
  show_default(io, f)

diff --git a/test/show.jl b/test/show.jl
@@ -506,6 +506,10 @@ end
 # Hidden macro names
 @test sprint(show, Expr(:macrocall, Symbol("@#"), nothing, :a)) == ":(@var\"#\" a)"
 
+# PR #38418
+module M1 var"#foo#"() = 2 end
+@test occursin("M1.var\"#foo#\"", sprint(show, M1.var"#foo#", context = :module=>@__MODULE__))
+
 # issue #12477
 @test sprint(show, Union{Int64, Int32, Int16, Int8, Float64}) == "Union{Float64, Int16, Int32, Int64, Int8}"