fix typo in issimple filtering in Logging (JuliaLang#38425)

inkydragon · Nov 17, 2020 · 3365b4e · 3365b4e
1 parent ef1b6d3
commit 3365b4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/base/logging.jl b/base/logging.jl
@@ -282,7 +282,7 @@ function issimple(@nospecialize val)
  val isa Number && return true
  val isa Char && return true
  if val isa Expr
- val.head === :quote && issimple(val[1]) && return true
+ val.head === :quote && issimple(val.args[1]) && return true
  val.head === :inert && return true
  end
  return false

diff --git a/test/corelogging.jl b/test/corelogging.jl
@@ -409,4 +409,8 @@ end
  @test record.group == :corelogging # name of this file
 end
 
+@testset "complicated kwargs logging macro" begin
+ @test_logs (:warn, "foo") @warn "foo" argvals=:((DoNotCare{$(Expr(:escape, :Any))}(),))
+end
+
 end