Skip to content

Commit

Permalink
Disarm watchdog timer at the end of the Sockets test (JuliaLang#38586)
Browse files Browse the repository at this point in the history
The Sockets test sets up a time bomb to go off after 10 minutes
(intended to give a backtrace if the Sockets test hangs), but
never disarms it, so it often just blows up whatever hapless
test happens to come after it.
  • Loading branch information
Keno committed Nov 27, 2020
1 parent 0f427e1 commit 0b1b5f7
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion stdlib/Sockets/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function killjob(d)
ccall(:uv_kill, Cint, (Cint, Cint), getpid(), Base.SIGTERM)
nothing
end
Timer(t -> killjob("KILLING BY SOCKETS TEST WATCHDOG\n"), 600)
sockets_watchdog_timer = Timer(t -> killjob("KILLING BY SOCKETS TEST WATCHDOG\n"), 600)

@testset "parsing" begin
@test ip"127.0.0.1" == IPv4(127,0,0,1)
Expand Down Expand Up @@ -617,3 +617,6 @@ end
end
end
end


close(sockets_watchdog_timer)

0 comments on commit 0b1b5f7

Please sign in to comment.