Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods fluent and also add more methods to class #17

Merged

Conversation

mantey-github
Copy link
Collaborator

I added some methods to the Tabula Class and also made some of the methods fluent.

  • setPdf(string $input): This method accepts the PDF file which needs to be converted. It returns the Tabula class

  • setOptions(array $options): This method accepts an array of options. These options are the options required by tabula.
    Options by default are:

[
        'pages' => null,
        'guess' => true,
        'area' => [],
        'relativeArea' => false,
        'lattice' => false,
        'stream' => false,
        'password' => null,
        'silent' => false,
        'columns' => null,
        'format' => null,
        'batch' => null,
        'outfile' => null,
]
  • buildOptions(array $options): This now accepts are the options required by tabula in an array form. Now the method is private

  • buildJavaOptions(): This method is currently private.

  • run(): This method is currently private.

  • convert(): This is the final method that has to be called to handle the conversion of the PDF file

@initred
Copy link
Owner

initred commented Apr 6, 2021

I'm sorry to see you late about the request.
Currently, the package has not been updated.
Also, thank you fr orequesting this fast-written code for the package that was left unattended.
I've read all the codes and it doesn't seem to be a problem.
We will merge and update that method.
I support you to be a good developer.
Thankyou.

@initred initred merged commit 2dd1c2a into initred:master Apr 6, 2021
@mantey-github
Copy link
Collaborator Author

I'm sorry to see you late about the request.
Currently, the package has not been updated.
Also, thank you fr orequesting this fast-written code for the package that was left unattended.
I've read all the codes and it doesn't seem to be a problem.
We will merge and update that method.
I support you to be a good developer.
Thankyou.

you're welcome

@mantey-github
Copy link
Collaborator Author

I'm sorry to see you late about the request.
Currently, the package has not been updated.
Also, thank you fr orequesting this fast-written code for the package that was left unattended.
I've read all the codes and it doesn't seem to be a problem.
We will merge and update that method.
I support you to be a good developer.
Thankyou.

I will create a pull request updating the README.md

Copy link
Owner

@initred initred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that time, I had no time, so I wrote all the codes in public. I remember. Haha. LOL. I'll take this into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants