Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): single pronounciation in JAWS/FF #1039

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

erikkroes
Copy link
Collaborator

@erikkroes erikkroes commented Oct 21, 2020

What I did

  1. Fixed some minor demo details
  2. Added aria-hidden to the SVG in the icon to hide it for FireFox

Fixes #172

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2020

🦋 Changeset detected

Latest commit: 978af94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/icon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@erikkroes erikkroes changed the title fix(icon): single pronounciation in JAWS/FF WIP: fix(icon): single pronounciation in JAWS/FF Oct 21, 2020
@erikkroes erikkroes changed the title WIP: fix(icon): single pronounciation in JAWS/FF fix(icon): single pronounciation in JAWS/FF Oct 21, 2020
@gerjanvangeest
Copy link
Member

Can you add a test?

And run yarn changeset to prepare a release.

@erikkroes
Copy link
Collaborator Author

Assuming I understand the tool, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icon] Double pronunciation in NVDA/FF
2 participants