OP-1152 renaming variable in hashCode method in Medical.java file #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted for resolution
…ted for resolution
…ted for resolution
…hod refactoring with build success and better readability
…hod refactoring with build success and better readability
…hod refactoring with build success and better readability
…bugging. Initially were not meaningful
Dharmil4602
changed the title
dbmalkovsky
reviewed
Nov 26, 2023
|
|
||
|
|
There was a problem hiding this comment.
Why are you including files that exist in another PR? (see https://github.com/informatici/openhospital-core/pull/1175/files). And none of the changes requested made in that PR are included here.
There was a problem hiding this comment.
I'll resolve it from my side.
mwithi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1152.
This pull request addresses code readability by applying the "Rename Variable" refactoring method to the hashCode method in Medical.java file. The primary change involves renaming the variable hash to hashValueMultiplier for improved clarity and self-documentation.
Changes Made:
Rationale:
Descriptive variable names enhance the understandability of the codebase. The new name, hashValueMultiplier, more accurately conveys the purpose of the variable in the context of the hashCode method. This refactoring aims to make the code more maintainable and accessible to developers.
Testing:
No functional changes have been made to the logic of the hashCode method. Existing unit tests for the class remain valid and continue to pass.
Link Before:
openhospital-core/src/main/java/org/isf/medicals/model/Medical.java
Line 4 in c9ce2c2
Link after modification: Dharmil4602@4aff137
Issue ID: https://openhospital.atlassian.net/browse/OP-1152