OP-336 Convert test to junit5 and test contextLoads() method #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emecas
reviewed
Jan 31, 2024
There was a problem hiding this comment.
That is exactly what I did, to verified it was working on, removing the comments from the test, no chance to test against the original issue running it on Eclipse.
I appreciate your effort in verifying that the loading context is working correctly. However, since this test does not provide any additional value and may actually slow down the tests execution, it's recommended to remove it. The loading context is implicitly tested by other tests that run as SpringBootTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-336.
Not sure if to have contextLoads() test though, by the moment it is slows down the whole test suite