Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate openapi check workflow from build one #423

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Jan 11, 2024

This is an alternative solution to #421 in order to separate the build (may success) and openapi generation (may fail).

@mwithi mwithi marked this pull request as ready for review January 11, 2024 00:35
@mwithi
Copy link
Member Author

mwithi commented Jan 11, 2024

@npasquetto after failing several attemps to have two subsequent jobs in the same worflow, I propose this version in place of #421 in order to separate the build (may success) and openapi generation (may fail).

Maybe we can further speed up by using the cache sharing between workflow (see here).
But, according with the execution time, maybe the setup-java is doing it by default.

Wdyt?

Copy link
Contributor

@npasquetto npasquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, consider whether it is appropriate to apply the proposed changes.

Unfortunately I was not able to successfully simulate the execution via the 'act' command but from the pipeline logs the workflow seems to have been successful.

@mwithi
Copy link
Member Author

mwithi commented Feb 27, 2024

@npasquetto can we merge this PR?

@mwithi mwithi merged commit 7859097 into develop Mar 27, 2024
4 checks passed
@mwithi mwithi deleted the mwithi-duplicate-openapi-job branch March 27, 2024 16:22
dbmalkovsky pushed a commit to dbmalkovsky/openhospital-api that referenced this pull request Apr 16, 2024
* Separate openapi check workflow from build one

* Apply suggestions

* Align with Java17
mwithi added a commit that referenced this pull request May 9, 2024
* OP-1207 move to Spring Boot 3.2.x

* Update pom.xml update to 1.14.1.SNAPSHOT

* Separate openapi check workflow from build one (#423)

* Apply suggestions

* Align with Java17

* OP-1207 JarLauncher class has moved

* OP-1234: fix tests releated to CORE changes in OP-1210

---------

Co-authored-by: Alessandro Domanico <[email protected]>
mwithi added a commit that referenced this pull request May 17, 2024
* Remove -SNAPSHOT

* Update version

* OP-1207 move to Spring Boot 3.2.x

* Update pom.xml update to 1.14.1.SNAPSHOT

* Update pom.xml

Co-authored-by: Alessandro Domanico <[email protected]>

* use jars consist with Spring Boot 3.2.x

* Separate openapi check workflow from build one (#423)

* Separate openapi check workflow from build one

* Apply suggestions

* Align with Java17

* OP-1207 JarLauncher class has moved

* OP-1207 JarLauncher class has moved

* Chore: update to SpringBoot 3.2.5

* Chore: update to SpringBoot 3.2.5; fix compile errors

* Chore: update to SpringBoot 3.2.5; update JarLauncher path

* OP-1235 Fix with new constructors (#443)

* Update pom

* Chore(deps): Bump license.maven.plugin.version from 4.3 to 4.5

Bumps `license.maven.plugin.version` from 4.3 to 4.5.

Updates `com.mycila:license-maven-plugin-git` from 4.3 to 4.5
- [Commits](mathieucarbou/license-maven-plugin@license-maven-plugin-4.3...license-maven-plugin-4.5)

Updates `com.mycila:license-maven-plugin` from 4.3 to 4.5
- [Commits](mathieucarbou/license-maven-plugin@license-maven-plugin-4.3...license-maven-plugin-4.5)

---
updated-dependencies:
- dependency-name: com.mycila:license-maven-plugin-git
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.mycila:license-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove -SNAPSHOT before release

* Align with develop and fix openapi

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alessandro Domanico <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants